Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for InstanceID as well when reading internal OVFs #761

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

shubhaOracle
Copy link
Contributor

@shubhaOracle shubhaOracle commented Nov 29, 2022

Detach 4.3 SD and attach it to 4.5 env fails with error 'Error parsing OVF due to OVF error: ol8-clone: cannot read 'rasd:InstanceId' with value: null'. Ref bug change https://bugzilla.redhat.com/show_bug.cgi?id=1850103

Steps -

  • Create a SD in 4.3 env
  • Add some test vms to this storage domain
  • Detach the SD from 4.3- Compute>Data Center> Click on the DC which has the concerned SD> Select the SD > Maintenance> Detach
  • Remove the SD from 4.3- Compute> Storage> Domains> Select the detached SD > Remove
  • Goto 4.4 env, Compute>Storage>Domain> Import Domain> add the exisiting path for the SD
  • Select the imported SD, goto VM Import tab, If your 4.4.10 env is not having the patch for the BUG, then the test VMs which were created in 4.3 under this SD , wont come up. The engine log will show an error w.r.t all the test VMs when you click on the VM import tab

@smelamud
Copy link
Member

Please reformat the commit message in accordance with oVirt standard. (You can take previous commits as an example.) And add more detailed explanation, how the patch fixes the problem.

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhaOracle thanks for posting this! your approach, checking both InstanceId and InstanceID, looks ok to me - but assuming this issue is specific to Oracle's product, I'd change the comment to avoid confusion and start with looking for InstanceId which is supposed to be there and then fall back to checking InstanceID

@shubhaOracle
Copy link
Contributor Author

I have added 'Signed-off-by:' to my second commit. I am not sure why it is still flagged as a problem.

@michalskrivanek
Copy link
Member

I have added 'Signed-off-by:' to my second commit. I am not sure why it is still flagged as a problem.

I think it checks it on all commits.
For this PR it makes sense to squash it into a single commit anyway

Issue:
When attaching SD, VM Import tab doesn't show a VM if VM OVF has 'InstanceID' instead of 'InstanceId' property. The engine log shows the below error.
'Error parsing OVF due to OVF error: ol8-clone: cannot read 'rasd:InstanceId' with value: null'.
Ref bug change https://bugzilla.redhat.com/show_bug.cgi?id=1850103

Fix:
When reading/parsing VM OVF, check for both values 'InstanceID' and 'InstanceId'.

Signed-off-by: Shubha Kulkarni <shubha.kulkarni@oracle.com>
@ahadas ahadas force-pushed the ovf-ovirt-instanceID-update branch from 4e7222e to 10ba646 Compare December 2, 2022 08:49
@ahadas ahadas changed the title Detach 4.3 SD and attach it to 4.4 env fails with error 'Error parsing OVF due to OVF error: ol8-clone: cannot read 'rasd:InstanceId' with value: null'. Ref bug change https://bugzilla.redhat.com/show_bug.cgi?id=1850103 Look for InstanceID as well when reading internal OVFs Dec 2, 2022
@ahadas
Copy link
Member

ahadas commented Dec 2, 2022

/ost

@ahadas ahadas merged commit 9493182 into oVirt:master Dec 2, 2022
@shubhaOracle shubhaOracle deleted the ovf-ovirt-instanceID-update branch December 5, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants